gh #358 signalEOS() description update by hari22yuva · Pull Request #359 · rdkcentral/rdk-halif-aidl

hari22yuva · 2026-03-19T15:49:48Z

No description provided.

Copilot

Pull request overview

Updates AIDL interface documentation for the audio/video decoder HALs to clarify post-signalEOS() behaviour and how EOS is indicated via FrameMetadata.endOfStream, aligning the contract discussed in gh #358 with the interface comments.

Changes:

Clarify decodeBuffer() return behaviour when signalEOS() has already been called.
Document that decodeBuffer() calls after signalEOS() (until flush/restart) must return false.
Refine FrameMetadata.endOfStream wording to describe EOS signalling on the final output callback.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`videodecoder/current/com/rdk/hal/videodecoder/IVideoDecoderController.aidl`	Updates `decodeBuffer()` / `signalEOS()` documentation to specify `false` after EOS until flush/restart.
`videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl`	Clarifies meaning/timing of `endOfStream` for video decoder output.
`audiodecoder/current/com/rdk/hal/audiodecoder/IAudioDecoderController.aidl`	Mirrors the video decoder documentation updates for audio decoder EOS behaviour.
`audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl`	Clarifies meaning/timing of `endOfStream` for audio decoder output (plus whitespace clean-up).

videodecoder/current/com/rdk/hal/videodecoder/IVideoDecoderController.aidl

audiodecoder/current/com/rdk/hal/audiodecoder/IAudioDecoderController.aidl

videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl

audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl

sensible changes Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Ulrond

works for me

Copilot

Pull request overview

Updates AIDL documentation to clarify end-of-stream (EOS) semantics for the audio/video decoder controllers and their FrameMetadata.endOfStream output flag, aligning expected decodeBuffer() behaviour after signalEOS().

Changes:

Document that decodeBuffer() returns false if called after signalEOS() until the decoder is flushed or restarted.
Clarify that FrameMetadata.endOfStream is an output flag set on the final frame callback after EOS, once all queued frames are output.
Minor whitespace cleanup in audio FrameMetadata.aidl.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
`videodecoder/current/com/rdk/hal/videodecoder/IVideoDecoderController.aidl`	Expands `decodeBuffer()`/`signalEOS()` documentation to specify post-EOS `decodeBuffer()` returns `false`.
`videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl`	Clarifies meaning/timing of `endOfStream` flag in decoder output metadata.
`audiodecoder/current/com/rdk/hal/audiodecoder/IAudioDecoderController.aidl`	Mirrors video controller doc updates for post-EOS `decodeBuffer()` behaviour.
`audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl`	Clarifies meaning/timing of `endOfStream` flag and removes trailing whitespace.

You can also share your feedback on Copilot code review. Take the survey.

bhanucbp

address review comments

bhanucbp · 2026-03-19T16:07:15Z

audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl

-	 * End of stream indicator.
+	 * End of stream flag for decoder output.
+	 * Set to true on the final frame output callback after signalEOS(), once all queued frames have been output.
+	 * This may correspond to an end of stream marker in the audio bitstream, when present.


audio bitstreams will not have eos markers present

bhanucbp · 2026-03-19T16:12:11Z

audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl

-	 * End of stream indicator.
+	 * End of stream flag for decoder output.
+	 * Set to true on the final frame output callback after signalEOS(), once all queued frames have been output.
+	 * This may correspond to an end of stream marker in the audio bitstream, when present.


there is dummy onFrameOutput call with -1 pts and null framehandle after signalEOS(). This info missing, add this info to onFrameOutput

Is this SOC specific implementation ?

No, this is not implementation-specific. The callback behavior should be explicitly documented; otherwise, the caller will not be aware of the final dummy frame.

bhanucbp · 2026-03-19T16:14:06Z

videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl

 	/**
-	 * End of stream marker found in the video bitstream.
+	 * End of stream flag for decoder output.
+	 * Set to true on the final frame output callback after signalEOS(), once all queued frames have been output.


its not on the final frame, there will be a dummy onFrameOutput with -1 pts and null frame handle after final frame delivered

Is this implementation specific ?

No, this is not implementation-specific. The behavior of the callbacks needs to be clearly defined; otherwise, the caller may not know that a final dummy frame (with invalid PTS and null handle) is delivered after signalEOS().

Copilot

Pull request overview

Updates the Audio/Video decoder AIDL interface documentation to clarify end-of-stream (EOS) behaviour, including how EOS affects subsequent buffer submission and how EOS is communicated in frame metadata.

Changes:

Documented that decodeBuffer() must return false after signalEOS() for both audio and video decoders.
Expanded FrameMetadata.endOfStream documentation to describe EOS signalling scenarios (including “EOS-only” callbacks).
Minor whitespace cleanup in audio FrameMetadata.aidl.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
videodecoder/current/com/rdk/hal/videodecoder/IVideoDecoderController.aidl	Adds post-`signalEOS()` `decodeBuffer()` behaviour note.
videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl	Expands `endOfStream` semantics for video output callbacks.
audiodecoder/current/com/rdk/hal/audiodecoder/IAudioDecoderController.aidl	Adds post-`signalEOS()` `decodeBuffer()` behaviour note.
audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl	Expands `endOfStream` semantics for audio output callbacks and removes trailing whitespace.

videodecoder/current/com/rdk/hal/videodecoder/IVideoDecoderController.aidl

audiodecoder/current/com/rdk/hal/audiodecoder/IAudioDecoderController.aidl

videodecoder/current/com/rdk/hal/videodecoder/FrameMetadata.aidl

audiodecoder/current/com/rdk/hal/audiodecoder/FrameMetadata.aidl

Ulrond

Let's discuss alternative option, this seems clearer to me longer term

#380

gh #358 signalEOS() description update

f7998dd

Copilot AI review requested due to automatic review settings March 19, 2026 15:49

github-project-automation bot added this to halif_aidl Mar 19, 2026

github-project-automation bot moved this to Architecture Review Required in halif_aidl Mar 19, 2026

Copilot AI reviewed Mar 19, 2026

View reviewed changes

hari22yuva linked an issue Mar 19, 2026 that may be closed by this pull request

Bug: signalEOS() description update #358

Open

Apply suggestions from code review

d5e2847

sensible changes Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 19, 2026 16:07

Ulrond previously approved these changes Mar 19, 2026

View reviewed changes

github-project-automation bot moved this from Architecture Review Required to Approved For Merge in halif_aidl Mar 19, 2026

Ulrond added documentation Improvements or additions to documentation component:audiodecoder SOC component: audiodecoder component:videodecoder SOC component: videodecoder labels Mar 19, 2026

Ulrond added this to the 0.14.0 milestone Mar 19, 2026

Ulrond self-assigned this Mar 19, 2026

Copilot AI reviewed Mar 19, 2026

View reviewed changes

bhanucbp reviewed Mar 19, 2026

View reviewed changes

Ulrond modified the milestones: 0.14.0, 0.15.0 Mar 23, 2026

Anbukannadhasan added 2 commits April 9, 2026 09:05

gh #358 Updated EOS metadata information in framemetadata

a22f4cf

gh #258 added EOS-only callback details in the spec

50ddfcf

Anbukannadhasan dismissed Ulrond’s stale review via 50ddfcf April 9, 2026 08:12

gh #358 corrected the review points

d93c3c7

Copilot AI review requested due to automatic review settings April 9, 2026 14:42

Copilot started reviewing on behalf of Anbukannadhasan April 9, 2026 14:46 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

gh #358 Corrected review comments

08b1b55

Ulrond reviewed Apr 10, 2026

View reviewed changes

Conversation

hari22yuva commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ulrond left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

bhanucbp left a comment

Choose a reason for hiding this comment

Uh oh!

bhanucbp Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

bhanucbp Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

hari22yuva Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhanucbp Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

bhanucbp Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

hari22yuva Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

bhanucbp Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ulrond left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hari22yuva Mar 19, 2026 •

edited

Loading